🐛 fix(action): skip uv install when already present - #23
Merged
Conversation
Users who run setup-uv earlier in their workflow get a redundant second installation when this action unconditionally calls setup-uv again. Detect uv on PATH before the install step and skip setup-uv if it's already available. This keeps the action self-contained for standalone use while avoiding duplicate installs in combined workflows. Closes tox-dev#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users who already run
setup-uvearlier in their workflow get a redundant second installation when this action unconditionally callssetup-uvagain. This wastes CI time downloading and setting up uv twice, as reported in #7.The action now checks whether
uvis already onPATHbefore running thesetup-uvstep. 🔧 If uv is detected, the install step is skipped entirely. This keeps the action fully self-contained for standalone use — when no priorsetup-uvexists, it installs uv as before — while avoiding duplicate work in combined workflows.Note: the comments on #7 also mention that the
pre-commit-uvPython package itself declaresuvas a dependency, causing yet another download inside the--withenvironment. That's a separate concern in thepre-commit-uvpackage, not this action.Closes #7